Skip to content

Remove legacy ESM CI job #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Remove legacy ESM CI job #11779

merged 1 commit into from
Nov 5, 2024

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Nov 4, 2024

Motivation

We can remove the CI step earlier to minimize the changes in the PR removing the legacy ESM feature (#11733) and mitigate merge conflicts.
Learned from the S3 example by @bentsku #11743

Changes

  • remove the legacy ESM CI job

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Nov 4, 2024
@joe4dev joe4dev added this to the 4.0 milestone Nov 4, 2024
@joe4dev joe4dev self-assigned this Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 20s ⏱️ +26s
3 532 tests ±0  3 118 ✅ ±0  414 💤 ±0  0 ❌ ±0 
3 534 runs  ±0  3 118 ✅ ±0  416 💤 ±0  0 ❌ ±0 

Results for commit a19259b. ± Comparison against base commit 1db9b8f.

@joe4dev joe4dev marked this pull request as ready for review November 4, 2024 22:17
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean preparation! 💯 🧹

@joe4dev joe4dev merged commit 04d3234 into master Nov 5, 2024
38 checks passed
@joe4dev joe4dev deleted the remove-legacy-esm-ci branch November 5, 2024 08:09
@joe4dev joe4dev mentioned this pull request Nov 5, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants