Skip to content

Introduce CONTAINER_RUNTIME environment variable to control all container runtimes #11793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Nov 6, 2024

Motivation

Currently, we only use the CONTAINER_RUNTIME environment variable in pro.
However, it makes sense to have this variable a global override, including for the lambda runtime executor.

For this, we need to move this variable to community.

Changes

  • Update tracked variables
  • Introduce CONTAINER_RUNTIME as environment variable in the open source project and make LAMBDA_RUNTIME_EXECUTOR fall back on it.

@dfangl dfangl requested a review from thrau as a code owner November 6, 2024 16:26
@dfangl dfangl added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Nov 6, 2024
@dfangl dfangl self-assigned this Nov 6, 2024
@dfangl dfangl requested a review from simonrw November 6, 2024 16:26
Copy link

github-actions bot commented Nov 6, 2024

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 41s ⏱️
423 tests 369 ✅  54 💤 0 ❌
846 runs  738 ✅ 108 💤 0 ❌

Results for commit 567cd7f.

Copy link

github-actions bot commented Nov 6, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 13s ⏱️ +8s
3 534 tests ±0  3 119 ✅ ±0  415 💤 ±0  0 ❌ ±0 
3 536 runs  ±0  3 119 ✅ ±0  417 💤 ±0  0 ❌ ±0 

Results for commit 567cd7f. ± Comparison against base commit 359f45f.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool new development! :-) looking forward to see this in action

@thrau thrau merged commit 0c04ec3 into master Nov 7, 2024
42 checks passed
@thrau thrau deleted the lambda/default-to-container-runtime branch November 7, 2024 15:29
zaingz pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants