Skip to content

move parse_service_name after serve_edge_router_rules #11800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

move parse_service_name after serve_edge_router_rules #11800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions localstack-core/localstack/aws/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ def __init__(self, service_manager: ServiceManager = None) -> None:
metric_collector.create_metric_handler_item,
load_service_for_data_plane,
handlers.preprocess_request,
handlers.parse_service_name, # enforce_cors and content_decoder depend on the service name
handlers.enforce_cors,
handlers.content_decoder,
handlers.content_decoder, # depends on preprocess_request for the S3 service
handlers.validate_request_schema, # validate request schema for public LS endpoints
handlers.serve_localstack_resources, # try to serve endpoints in /_localstack
handlers.serve_edge_router_rules,
# start aws handler chain
handlers.parse_service_name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: This absolutely minimal change is the result of a lot of work. Thanks for staying at it, absolutely fantastic to see this moving down! 💯 🥳 ‏

handlers.parse_pre_signed_url_request,
handlers.inject_auth_header_if_missing,
handlers.add_region_from_header,
Expand Down
Loading