Skip to content

fix node installation in Dockerfile #11808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix node installation in Dockerfile #11808

merged 1 commit into from
Nov 7, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Nov 7, 2024 •
edited
Loading

Motivation

Recently the NodeJS installation failed when building the Docker image with the following error:

#8 6.843 + cat+ uniq
#8 6.844  SHASUMS256.txt
#8 6.845 + sort
#8 6.846 + grep -o node-v.*-linux-x64
#8 6.847 + LATEST_VERSION_FILENAME=
#8 6.847 + rm SHASUMS256.txt
#8 6.848 + curl -fsSLO --compressed https://nodejs.org/dist/latest-v18.x/.tar.xz
#8 6.985 curl: (22) The requested URL returned error: 404

Here are some examples of failing pipelines:

This is due to an issue with how the NodeJS servers are configured.
https://nodejs.org/dist/latest-v18.x/ does not directly respond anymore, but redirects to the respective folder:

$ curl -v https://nodejs.org/dist/latest-v18.x/SHASUMS256.txt
...
< location: https://nodejs.org/dist/v18.20.4/SHASUMS256.txt
...

Changes

  • Fix the node installation by adding the latest GPG key and follow redirects when downloading the SHASUM256.txt

@alexrashed alexrashed self-assigned this Nov 7, 2024
@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Nov 7, 2024
@alexrashed alexrashed added this to the 4.0 milestone Nov 7, 2024
@alexrashed alexrashed requested review from simonrw and joe4dev November 7, 2024 17:05
@alexrashed alexrashed marked this pull request as ready for review November 7, 2024 17:05
joe4dev
joe4dev approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Build is 🟢

nice key addition sneaked in as well :)

@alexrashed alexrashed merged commit 7a02a30 into master Nov 7, 2024
19 of 25 checks passed
@alexrashed alexrashed deleted the fix-node-installation branch November 7, 2024 17:11
@alexrashed alexrashed mentioned this pull request Nov 7, 2024
Merged
zaingz pushed a commit that referenced this pull request Nov 11, 2024
@alexrashed @zaingz
fix node installation in Dockerfile (#11808)
97161f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@simonrw simonrw Awaiting requested review from simonrw

Assignees

@alexrashed alexrashed

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrashed @joe4dev