Skip to content

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Nov 7, 2024

Motivation

Adresses #11537. This PR extends the list of attributes that need to be converted in a EventPattern inside the resource provider for AWS::Events::Rule
Operations added are found in this AWS doc

Changes

  • simple addition of operations to the list of atts to be converted

Testing

  • new aws validated test.

Copy link

github-actions bot commented Nov 7, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 52m 12s ⏱️ +10s
3 817 tests +1  3 499 ✅ +1  318 💤 ±0  0 ❌ ±0 
3 819 runs  +1  3 499 ✅ +1  320 💤 ±0  0 ❌ ±0 

Results for commit c68971c. ± Comparison against base commit 78fdf45.

♻️ This comment has been updated with latest results.

@pinzon pinzon added the semver: patch Non-breaking changes which can be included in patch releases label Nov 8, 2024
@pinzon pinzon marked this pull request as ready for review November 11, 2024 14:20
@pinzon pinzon marked this pull request as draft November 11, 2024 14:21
@pinzon pinzon added this to the 4.1 milestone Nov 13, 2024
@pinzon pinzon force-pushed the fix-cfn-events-rule branch from 6d05676 to 12d861e Compare December 3, 2024 19:02
@pinzon pinzon changed the title wip: fix suffix transform in aws::events::rule fix transformation for matching operations in aws::events::rule Dec 3, 2024
Copy link
Member

@maxhoheiser maxhoheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition - the failing tests kinesis-firehose-s3 prbly is a flake - feel free to merge once it passes :)

@pinzon pinzon marked this pull request as ready for review December 4, 2024 19:00
@pinzon pinzon merged commit 891ed23 into master Dec 4, 2024
35 checks passed
@pinzon pinzon deleted the fix-cfn-events-rule branch December 4, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants