Idempotent start of the DynamoDB server #11815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 26m 34s ⏱️ - 1h 16m 18s Results for commit 74e1c23. ± Comparison against base commit d08dfc5. This pull request removes 2668 tests.♻️ This comment has been updated with latest results. |
| @@ -79,6 +79,10 @@ def get() -> "DynamodbServer": | |||
| def start_dynamodb(self) -> bool: | |||
| """Start the DynamoDB server.""" | |||
|
|
|||
| # We want this method to be idempotent. | |||
| if self.is_running() and self.is_up(): | |||
| return True | |||
There was a problem hiding this comment.
Would this be invoked in a multi-threaded environment? If so, this should happen within the context of a mutex.
There was a problem hiding this comment.
Good point! I annotated the start_dynamodb function as we already do with stop_dynamodb. I think this should suffice.
zaingz
pushed a commit
that referenced
this pull request
Nov 11, 2024
zaingz
pushed a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a follow-up of #11789.
@HarshCasper noticed a bunch of logs like the following when loading a DDB state in a container without an initialized DDB provider (i.e., start LS and immediately load):
One can simply verify the behavior with:
This described scenario triggers these provider hooks in the following order:
on_after_state_load, which starts the DDB server on a given port viaDynamodbServer::start_dynamodb;on_before_start, which also callsDynamodbServer::start_dynamodband tries to start DDB once again on the same port, causing the issue above.Changes
start_dynamoddbthat verifies if the thread is already running and healthy, making the function idempotent.ext pipeline to make sure persistence works correctly.