Skip to content

Update broken links in localstack-concepts/Readme.md #11820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

Update broken links in localstack-concepts/Readme.md #11820

merged 1 commit into from
Nov 11, 2024

Conversation

dance-cmdr
Copy link
Contributor

@dance-cmdr dance-cmdr commented Nov 9, 2024 •
edited
Loading

Motivation

#11819 & OCD!
I was reading the documentation and I found some broken links. I think they need some love and it will help new joiners.

Changes

  • Updates 5 links to localstack resources that are out of date since the refactoring.
Before After
Screenshot 2024-11-09 at 23 12 32 Screenshot 2024-11-09 at 23 14 42

Testing

  • Visit each of the changed links and click them. They should lead you to the correct localstack resource.

localstack-bot
localstack-bot reviewed Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Collaborator

localstack-bot commented Nov 9, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dance-cmdr dance-cmdr changed the title docs(localstack-concepts): update broken links update broken links in localstack-concepts/Readme.md Nov 9, 2024
@dance-cmdr dance-cmdr changed the title update broken links in localstack-concepts/Readme.md Update broken links in localstack-concepts/Readme.md Nov 9, 2024
@dance-cmdr
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

@dance-cmdr
Copy link
Contributor Author

dance-cmdr seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

New machine and pointing to a new email. That have been rectified in GitHub but we might need to rerun the job.

@HarshCasper HarshCasper added the semver: patch Non-breaking changes which can be included in patch releases label Nov 11, 2024
HarshCasper
HarshCasper approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!

localstack-bot added a commit that referenced this pull request Nov 11, 2024
@localstack-bot
@dance-cmdr has signed the CLA in #11820
3f0ab3b
@HarshCasper HarshCasper merged commit f020c22 into localstack:master Nov 11, 2024
9 of 14 checks passed
zaingz pushed a commit that referenced this pull request Nov 11, 2024
@dance-cmdr @zaingz
Update broken links in localstack-concepts/README.md (#11820)
ad97644
zaingz pushed a commit that referenced this pull request Nov 13, 2024
@dance-cmdr @zaingz
Update broken links in localstack-concepts/README.md (#11820)
5d8954d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@HarshCasper HarshCasper HarshCasper approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dance-cmdr @localstack-bot @HarshCasper