Skip to content

Switch Lambda debug path analytics to presense #11859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Nov 18, 2024

Motivation

Paths might contain sensitive information, so we had better only track its presence.

Changes

Switch to presence detection rather than tracking the path value.

Questions

Could such a switch cause data analytics/quality challenges in Tinybird @ackdav ?

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Nov 18, 2024
@joe4dev joe4dev added this to the 4.0 milestone Nov 18, 2024
@joe4dev joe4dev self-assigned this Nov 18, 2024
@joe4dev joe4dev requested a review from thrau as a code owner November 18, 2024 10:39
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   3m 52s ⏱️ -5s
421 tests ±0  369 ✅ ±0   52 💤 ±0  0 ❌ ±0 
842 runs  ±0  738 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit efabc92. ± Comparison against base commit 939b99d.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 43m 28s ⏱️ -34s
3 526 tests ±0  3 133 ✅ ±0  393 💤 ±0  0 ❌ ±0 
3 528 runs  ±0  3 133 ✅ ±0  395 💤 ±0  0 ❌ ±0 

Results for commit efabc92. ± Comparison against base commit 939b99d.

Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to make sure @ackdav is aware of the change and reason.

@joe4dev joe4dev merged commit bd86cb5 into master Nov 20, 2024
43 checks passed
@joe4dev joe4dev deleted the switch-lambda-debug-analytics branch November 20, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants