Skip to content

Add restructurings to fix events persistence in v2 #11889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add restructurings to fix events persistence in v2 #11889

merged 1 commit into from
Nov 21, 2024

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Nov 21, 2024 •
edited by joe4dev
Loading

Motivation

EventBridge v2 does not yet support persistence. This PR restructures the community provider and fixes a small store typo for correct store discovery.

Changes

  • Restructure EventBridge v2 provider service creations for persistence
  • Fix typo in stores model

@dfangl dfangl self-assigned this Nov 21, 2024
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Nov 21, 2024
dominikschubert
dominikschubert reviewed Nov 21, 2024
View reviewed changes
localstack-core/localstack/services/events/models.py
@@ -237,4 +237,4 @@ class EventsStore(BaseStore):
TAGS: TaggingService = CrossRegionAttribute(default=TaggingService)


events_store = AccountRegionBundle("events", EventsStore)
events_stores = AccountRegionBundle("events", EventsStore)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: this was the main reason why the store wasn't being picked up by the state visitor as the _stores suffix is a requirement for automatic detection.

@joe4dev joe4dev added this to the 4.0 milestone Nov 21, 2024
@dominikschubert dominikschubert self-requested a review November 21, 2024 10:34
dominikschubert
dominikschubert approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work on fixing it in record time 🚀

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 2m 42s ⏱️ - 40m 44s
2 026 tests  - 1 539  1 906 ✅  - 1 323  120 💤  - 216  0 ❌ ±0 
2 028 runs   - 1 539  1 906 ✅  - 1 323  122 💤  - 216  0 ❌ ±0 

Results for commit 7e07d72. ± Comparison against base commit 3be7ae0.

This pull request removes 1539 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@dfangl dfangl merged commit 6748e0e into master Nov 21, 2024
38 of 39 checks passed
@dfangl dfangl deleted the events/fix-persistence branch November 21, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@maxhoheiser maxhoheiser Awaiting requested review from maxhoheiser maxhoheiser is a code owner

@joe4dev joe4dev Awaiting requested review from joe4dev

Assignees

@dfangl dfangl

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dfangl @dominikschubert @joe4dev