Skip to content

Re-introduce EventBridge invoke analytics #11893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

Re-introduce EventBridge invoke analytics #11893

merged 1 commit into from
Nov 22, 2024

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Nov 21, 2024 •
edited
Loading

Changes

Re-introduce EventBridge analytics removed by accident in #11880

@joe4dev joe4dev added this to the 4.0 milestone Nov 21, 2024
@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Nov 21, 2024
@joe4dev joe4dev self-assigned this Nov 21, 2024
@joe4dev joe4dev modified the milestones: 4.0, 4.0.1 Nov 21, 2024
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 2m 54s ⏱️ - 38m 44s
2 026 tests  - 1 539  1 906 ✅  - 1 323  120 💤  - 216  0 ❌ ±0 
2 028 runs   - 1 539  1 906 ✅  - 1 323  122 💤  - 216  0 ❌ ±0 

Results for commit d4e3088. ± Comparison against base commit 6748e0e.

This pull request removes 1539 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@joe4dev joe4dev marked this pull request as ready for review November 21, 2024 13:32
@joe4dev joe4dev requested a review from maxhoheiser as a code owner November 21, 2024 13:32
@joe4dev joe4dev changed the title Readd EventBridge invoke analytics Re-introduce EventBridge invoke analytics Nov 22, 2024
@dominikschubert dominikschubert self-requested a review November 22, 2024 08:45
dominikschubert
dominikschubert approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe4dev joe4dev merged commit 91394ca into master Nov 22, 2024
45 checks passed
@joe4dev joe4dev deleted the re-add-events-analytics branch November 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@maxhoheiser maxhoheiser Awaiting requested review from maxhoheiser

Assignees

@joe4dev joe4dev

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@joe4dev @dominikschubert