Skip to content

StepFunctions: Support Comments in Comparison Composite Statement Lists #11956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

StepFunctions: Support Comments in Comparison Composite Statement Lists #11956

merged 1 commit into from
Nov 28, 2024

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Nov 28, 2024

Motivation

Currently the SFN v2 interpreter does not allow for "Comment" fields in comparison composite statement lists, such as in:

    ...
    "Choices": [
      {
        "And": [
          {
            ...
          }
        ],
        "Comment": "comment text",
        ...
      }
    ],
    ...

this is despite allowing for such bindings in the preprocessor already. These changes add parsing support for comments in such productions and add a related snapshot test.

Changes

  • updated parser grammar to allow for comment declarations in comparison composite statement lists
  • updated comments test case to include this scenario

@MEPalma MEPalma self-assigned this Nov 28, 2024
@MEPalma MEPalma added the semver: patch Non-breaking changes which can be included in patch releases label Nov 28, 2024
gregfurman
gregfurman approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@gregfurman gregfurman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ran this updated test against HEAD of master and your feature branch, and all looks great.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   34m 36s ⏱️ - 1h 13m 25s
1 264 tests  - 2 511  1 171 ✅  - 2 258  93 💤  - 253  0 ❌ ±0 
1 266 runs   - 2 511  1 171 ✅  - 2 258  95 💤  - 253  0 ❌ ±0 

Results for commit 2e689dd. ± Comparison against base commit 1a46f58.

This pull request removes 2511 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@MEPalma MEPalma merged commit 892eb4d into master Nov 28, 2024
34 of 36 checks passed
@MEPalma MEPalma deleted the MEP-sfn-comments_comparison_composite branch November 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregfurman gregfurman gregfurman approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@MEPalma MEPalma

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @gregfurman