Skip to content

fix ASF code generation for recursive structures with keywords #11972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix ASF code generation for recursive structures with keywords #11972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9188023
fix type quoting on recursive typed dicts
alexrashed Dec 2, 2024
ea27811
set args positional everywhere
alexrashed Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions localstack-core/localstack/aws/scaffold.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,11 @@ def dependencies(self) -> List[str]:

def _print_structure_declaration(self, output, doc=True, quote_types=False):
if self.is_exception:
self._print_as_class(output, "ServiceException", doc)
self._print_as_class(output, "ServiceException", doc, quote_types)
return

if any(map(is_keyword, self.shape.members.keys())):
self._print_as_typed_dict(output)
self._print_as_typed_dict(output, doc, quote_types)
return

if self.is_request:
Expand Down
Loading