Add test for EventBridge Scheduler TagResource API and UntagResource API #11976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kakakakakku thanks for your contribution - looking great - at localstack we also generate snapshots from the responses from real AWS environments to guarantee that we have parity. I will add a snapshot for your test and create the snapshots for you since it is not straight forward and requires an AWS account. |
|
OK, thanks! |
Just added them for you :) feel free to merge once all the tests re green |
maxhoheiser
approved these changes
Dec 4, 2024
bafcded to
acdacd1
Compare
|
@maxhoheiser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hi😀
I checked the EventBridge Scheduler API coverage and found that some APIs were not marked in the "Internal Test Suite". So I wanted to contribute by adding tests.
Changes
In this Pull Request, I’ve added a test for the EventBridge Scheduler
TagResourceAPI andUntagResourceAPI to improve coverage.It's a bit hard to understand, but the
TagResourceAPI andUntagResourceAPI are not for EventBridge Scheduler, It's specifically for EventBridge Scheduler Group.Testing
The tests passed in my local environment.
$ make test TEST_PATH=tests/aws/services/scheduler (snip) tests/aws/services/scheduler/test_scheduler.py::test_tag_resource PASSED [ 66%] tests/aws/services/scheduler/test_scheduler.py::test_untag_resource PASSED [100%]Could you please review? Thanks a lot 👍
I am also submitting some pull requests. I would appreciate it if you could take a look at that as well. Thanks.