Events: EventRuleEngine: improve cidr to support ipv6 and better validation
#11981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8c5081 to
752b519
Compare
LocalStack Community integration with Pro 2 files 2 suites 1h 8m 11s ⏱️ Results for commit 04b940f. ♻️ This comment has been updated with latest results. |
752b519 to
04b940f
Compare
maxhoheiser
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After backporting
cidrback to SNS, @cloutierMat made a really solid point in his review:#11979 (comment)
After improving it for SNS, I'm backporting it back again to
eventsChanges
cidrsupport for IPv6, and better validation