StepFunctions: Base Support for Task Credentials #11987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfurman
approved these changes
Dec 11, 2024
...k/services/stepfunctions/asl/component/state/state_execution/state_task/state_task_lambda.py
Show resolved
Hide resolved
localstack-core/localstack/services/stepfunctions/asl/utils/boto_client.py
Outdated
Show resolved
Hide resolved
localstack-core/localstack/services/stepfunctions/asl/utils/boto_client.py
Show resolved
Hide resolved
| _THIS_FOLDER: Final[str] = os.path.dirname(os.path.realpath(__file__)) | ||
|
|
||
|
|
||
| class CredentialsTemplates(TemplateLoader): |
There was a problem hiding this comment.
Wanna just clarify that we will only ever need the Credentials field when doing cross-account integrations? (see docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the SFN v2 interpreter does not support cross account task invocations due to the lack of support of Credentials blocks (#11927, #11311). These changes add base support and testing setup for this feature.
Furthermore, this resolves an issue where optimised service integration with support for
.syncoperations but not.waitForTaskTokenwould bypass the setup of the callback endpoint but later attempt to listen for it, leading toStates.Runtimeexceptions when initiating the sync callback routine.Changes
TODO
What's left to do: