Skip to content

[ESM] Raise exception when setting DestinationConfig.OnSuccess #11989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

[ESM] Raise exception when setting DestinationConfig.OnSuccess #11989

merged 1 commit into from
Dec 5, 2024

Conversation

gregfurman
Copy link
Contributor

Motivation

Although the AWS docs indicates we can use a DestinationConfig object's OnSuccess in ESM, this is actually not supported. This PR adds a parity test and raises an exception for the aforementioned case.

Changes

  • Added parity test with raised exception
  • Raise exception in LS on ESM validation

@gregfurman gregfurman self-assigned this Dec 5, 2024
@gregfurman gregfurman added type: feature New feature, or improvement to an existing feature aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) labels Dec 5, 2024
@gregfurman gregfurman added this to the Playground milestone Dec 5, 2024
@gregfurman gregfurman added semver: patch Non-breaking changes which can be included in patch releases and removed type: feature New feature, or improvement to an existing feature labels Dec 5, 2024
joe4dev
joe4dev approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch 👏

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

LocalStack Community integration with Pro

    2 files  ±  0      2 suites  ±0   1h 27m 7s ⏱️ - 23m 19s
2 881 tests  - 946  2 660 ✅  - 849  221 💤  - 97  0 ❌ ±0 
2 883 runs   - 946  2 660 ✅  - 849  223 💤  - 97  0 ❌ ±0 

Results for commit eef1b2d. ± Comparison against base commit 891ed23.

This pull request removes 946 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@gregfurman gregfurman marked this pull request as ready for review December 5, 2024 12:42
@gregfurman gregfurman merged commit fd580a2 into master Dec 5, 2024
39 of 40 checks passed
@gregfurman gregfurman deleted the fix/esm/on-success-cfg branch December 5, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@dfangl dfangl Awaiting requested review from dfangl

Assignees

@gregfurman gregfurman

Labels
aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@gregfurman @joe4dev