Skip to content

[SFN] Correctly record failed EventsBridge PUT requests #11991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

[SFN] Correctly record failed EventsBridge PUT requests #11991

merged 1 commit into from
Dec 6, 2024

Conversation

gregfurman
Copy link
Contributor

@gregfurman gregfurman commented Dec 5, 2024 •
edited
Loading

Motivation

This PR fixes the construction of EventsBridge PUT failures -- as well as recording them to the execution history. Relies on changes in #11990

Changes

  • Remove skips on events tests.
  • Adds another test to ensure we can handle the mixed case where some entries are malformed and some are valid.
  • Pass the PUT response as the cause of the failure event when constructing failed events.

@gregfurman gregfurman self-assigned this Dec 5, 2024
@gregfurman gregfurman added aws:stepfunctions AWS Step Functions semver: patch Non-breaking changes which can be included in patch releases labels Dec 5, 2024
@gregfurman gregfurman added this to the Playground milestone Dec 5, 2024
Base automatically changed from fix/eventsbridge/malformed-detail-field to master December 6, 2024 11:30
@gregfurman gregfurman force-pushed the fix/sfn/malformed-events branch from d299d51 to 97f5524 Compare December 6, 2024 11:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

LocalStack Community integration with Pro

    2 files      2 suites   35m 27s ⏱️
1 313 tests 1 250 ✅ 63 💤 0 ❌
1 315 runs  1 250 ✅ 65 💤 0 ❌

Results for commit 97f5524.

@gregfurman gregfurman marked this pull request as ready for review December 6, 2024 12:13
MEPalma
MEPalma approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@MEPalma MEPalma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregfurman gregfurman merged commit abce2b5 into master Dec 6, 2024
31 checks passed
@gregfurman gregfurman deleted the fix/sfn/malformed-events branch December 6, 2024 13:33
@gregfurman gregfurman mentioned this pull request Dec 10, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MEPalma MEPalma MEPalma approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@gregfurman gregfurman

Labels
aws:stepfunctions AWS Step Functions semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@gregfurman @MEPalma