make SNS SigningCertURL configurable even if not resolvable
#11993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 5m 19s ⏱️ Results for commit b2f78be. |
cloutierMat
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported by #11850, some SDK will verify the
SigningCertURLfield host part even if not validating the messages.This PR introduces a config flag to allow the user to set the host of the
SigningCertURLto pass those regex pattern, even if the host is then non-resolvable, it should at least unblock the user, as they confirmed this would be sufficient for their use case.Changes
SNS_CERT_URL_HOSTto allow the user the set the host to an arbitrary valuefixes #11850
TODO
What's left to do: