Refactor/events: Custom api destination and connection tests #11999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files 2 suites 1h 52m 41s ⏱️ Results for commit f4d8f31. ♻️ This comment has been updated with latest results. |
zaingz
reviewed
Dec 9, 2024
| policyName=policy_name, policyDocument=json.dumps(resource_policy) | ||
| ) | ||
| class TestEventsTargetApiDestination: | ||
| # TODO validate against AWS |
There was a problem hiding this comment.
Is there a particular reason for not validating against AWS? I would prefer to validate it against AWS so we don't have to revisit this.
There was a problem hiding this comment.
this pr is only refactoring no changes per see - also would be great if you can do this since you are now more familiar with this test and API endpoints
8b9c3bd to
382cc1c
Compare
zaingz
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep test cleanly separated into separate test files where reasonable to improve readability of test files.
We have a separate test file for testing event bridge targets.
It also makes sense to separate API endpoints and connections functionality in a separate test file.
Changes