Unskip supported Lambda and ESM tests #12012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 30m 58s ⏱️ - 21m 46s Results for commit 46fac99. ± Comparison against base commit 630f782. This pull request removes 950 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
joe4dev
commented
Dec 11, 2024
| @markers.snapshot.skip_snapshot_verify(paths=["$..CodeSize"]) | ||
| @markers.snapshot.skip_snapshot_verify( | ||
| paths=[ | ||
| # Lambda ZIP flaky in CI |
There was a problem hiding this comment.
@dfangl @dominikschubert Is that assumption correct?
There was a problem hiding this comment.
Usually yes, we cannot totally rely on this, as it might change.
pinzon
reviewed
Dec 11, 2024
Comment on lines
+56
to
+58
| # TODO: Fix flaky ESM state mismatch upon update in LocalStack (expected Enabled, actual Disabled) | ||
| # This might be a parity issue if AWS does rolling updates (i.e., never disables the ESM upon update). | ||
| "$..EventSourceMappings..State", |
ca5538a to
376b6a9
Compare
dfangl
approved these changes
Dec 13, 2024
| @@ -233,7 +234,7 @@ | |||
| "partitionKey": "test_0", | |||
| "sequenceNumber": "<sequence-number:1>", | |||
| "data": "eyJyZWNvcmRfaWQiOiAwfQ==", | |||
| "approximateArrivalTimestamp": "timestamp" | |||
| "approximateArrivalTimestamp": "<approximate-arrival-timestamp>" | |||
There was a problem hiding this comment.
Would be nice to get the timestamp - format - matching here in the future!
| @@ -75,3 +73,9 @@ | |||
| "last_validated_date": "2024-10-12T13:23:12+00:00" | |||
| } | |||
| } | |||
| " | |||
There was a problem hiding this comment.
Good catch, the entire validations file was messed up 😆
Re-generated from scratch ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the many Lambda and ESM v2 improvements, we can unskip tests and enable snapshot validations.
Changes