Print web app URL in CLI start command #12016
Conversation
| @@ -908,6 +909,10 @@ def print_profile() -> None: | |||
| f" :bust_in_silhouette: [bold]Profile:[/bold] [blue]{', '.join(config.LOADED_PROFILES)}[/blue]" | |||
| ) | |||
|
|
|||
| def print_app() -> None: | |||
| console.print( | |||
| f" :globe_with_meridians: [bold]App:[/bold] \033https://app.localstack.cloud\033" | |||
There was a problem hiding this comment.
note: Alternatively, we could use a short URL like https://localstack.dev/app so we can track usage.
There was a problem hiding this comment.
Thanks a lot for the addition and the great PR description with the screenshots! 🚀
Some checks on your PR are currently failing, but they are easy to fix:
- "Enforce PR Labels" fails because you need to define the semver for your change by setting one of the
semver: <bump-type>labels. - "ci/circleci: preflight" fails because your code is not passing our linting rules.
- You can easily fix that by using the
make formatandmake lintcommands. - You can make sure that this is checked before each of your local commits by installing our pre-commit rules with
make init-precommit.
- You can easily fix that by using the
Let me know if you need any help :)
|
Awesome—thanks for the hints, @alexrashed!
Could you take another look and let me know what you think about this change? 😃 |
There was a problem hiding this comment.
Thanks a lot for addressing the comments! I think it is looking great! 🚀
But we should clarify the two comments before merging.
Also, please be aware that the changes in the CLI will only take effect with the next release and not immediately after the merge to master.
Other than the emulator Docker image, we only publish the CLI on explicit tagged releases.
|
Thanks for the insights and taking another look, @alexrashed!
Sounds good—there'a absolutely no rush to get this in. Addressed both discussions above. Since we're here I thought we could consider also dropping the emojis at the start now that it's getting crowded up there to make it a bit more professional—happy to keep the emojis in. What do you think?
|
|
Thanks, @alexrashed! ❤️ Removed the emojis as they also become harder to see in dark themes, and updated the PR description to reflect the latest changes. Merging once the checks pass. 🚀 |
This will update the CLI output to include the web app URL added in #12016.
This will update the CLI output to include the web app URL added in #12016.
This will update the CLI output to include the web app URL added in #12016.
Motivation
See relevant discussion where initially the idea of linking to the web app was mentioned.
Changes