Skip to content

Replicator implement cfn read for supported resources #12017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 11, 2024
Merged

Replicator implement cfn read for supported resources #12017

merged 6 commits into from
Dec 11, 2024

Conversation

cloutierMat
Copy link
Contributor

Motivation

Base implementation of get and list CloudFormation operation for Vpc, Subnet, KmsKey, and secret. This is in a continued effort to further the work with the cloudcontrol api.

Changes

  • Endpoint implementation
  • Refresh of specs where needed

@cloutierMat cloutierMat added aws:cloudformation AWS CloudFormation semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Dec 11, 2024
@cloutierMat cloutierMat added this to the 4.1 milestone Dec 11, 2024
@cloutierMat cloutierMat self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0    2 suites  ±0   22m 32s ⏱️ - 1h 27m 7s
1 026 tests  - 2 855  904 ✅  - 2 661  122 💤  - 194  0 ❌ ±0 
1 028 runs   - 2 855  904 ✅  - 2 661  124 💤  - 194  0 ❌ ±0 

Results for commit ff5fc1e. ± Comparison against base commit abb35c3.

This pull request removes 2855 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni removed their request for review December 11, 2024 13:53
pinzon
pinzon approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR 👍 Just a minor suggestion

localstack-core/localstack/services/ec2/resource_providers/aws_ec2_subnet.py
Comment on lines +44 to +46
def generate_subnet_read_payload(
ec2_client, schema, subnet_ids: Optional[list[str]] = None
) -> list[EC2SubnetProperties]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Seems like generate_subnet_read_payload could be use it for both list and read like you did in other resource providers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes! That was the goal. Forgot to update that one! Thanks for the catch! 🙏

@cloutierMat cloutierMat merged commit 412122d into master Dec 11, 2024
31 checks passed
@cloutierMat cloutierMat deleted the replicator-implement-cfn-read-for-supported-resources branch December 11, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@macnev2013 macnev2013 Awaiting requested review from macnev2013

@MEPalma MEPalma Awaiting requested review from MEPalma

@sannya-singal sannya-singal Awaiting requested review from sannya-singal

@simonrw simonrw Awaiting requested review from simonrw

Assignees

@cloutierMat cloutierMat

Labels
aws:cloudformation AWS CloudFormation semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cloutierMat @pinzon