fix APIGW transformers to not do value replacement on port #12021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutierMat
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@dfangl encountered a flake in an APIGW test which was quite unlikely, due to a port field (usually
443) being present in a UUID and breaking the snapshot replacement.https://app.circleci.com/pipelines/github/localstack/localstack/30209/workflows/d7b445e5-43ba-4686-8d83-73a0c370d721/jobs/267451/tests
side-note: the content length changing between snapshots might mean we should transform it, it runs against AWS again when run but might change over time. We can always look into it in a follow up
Changes