Skip to content

add read/list methods for ec2 security-groups resource provider #12034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 20, 2024
Merged

add read/list methods for ec2 security-groups resource provider #12034

merged 8 commits into from
Dec 20, 2024

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Dec 13, 2024 •
edited
Loading

Motivation

This PR adds the Operations for READ and LIST to the Resource Provider for AWS::Ec2::SecurityGroup

cc/ @cloutierMat @simonrw

Changes

  • Read and List operations
  • Fix the setting of a custom ID in the Patches

Testing

  • These operations are use by CloudControl only. That service is not available in this repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

LocalStack Community integration with Pro

 2 files  ±    0   2 suites  ±0   24s ⏱️ - 1h 54m 48s
22 tests  - 3 878  20 ✅  - 3 568  2 💤  - 305  0 ❌  - 5 
24 runs   - 3 878  20 ✅  - 3 568  4 💤  - 305  0 ❌  - 5 

Results for commit 7bd94f6. ± Comparison against base commit 1dba4f3.

This pull request removes 3878 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@pinzon pinzon force-pushed the cfn/read-methods-for-sg branch from 664b452 to e45c429 Compare December 13, 2024 15:38
@pinzon pinzon force-pushed the cfn/read-methods-for-sg branch from 29d5b28 to 1d56ade Compare December 17, 2024 18:37
@pinzon pinzon added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Dec 17, 2024
pinzon
pinzon commented Dec 17, 2024
View reviewed changes
localstack-core/localstack/services/ec2/patches.py
Comment on lines 128 to -138
if custom_id:
# Remove the security group from the default dict and add it back with the custom id
self.groups[vpc_id].pop(result.group_id)
self.groups[result.vpc_id].pop(result.group_id)
result.group_id = result.id = custom_id
self.groups[vpc_id][custom_id] = result
Copy link
Member Author

@pinzon pinzon Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patched method already searches for the default VpcId and assigns it to the SG

@pinzon pinzon changed the title wip: add read/list methods for ec2 security-groups resource provider add read/list methods for ec2 security-groups resource provider Dec 17, 2024
@pinzon pinzon force-pushed the cfn/read-methods-for-sg branch from 299e448 to ecf6707 Compare December 17, 2024 19:26
@pinzon pinzon marked this pull request as ready for review December 17, 2024 20:04
@pinzon pinzon merged commit d6e0887 into master Dec 20, 2024
31 checks passed
@pinzon pinzon deleted the cfn/read-methods-for-sg branch December 20, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinzon @viren-nadkarni