Skip to content

Conversation

alexrashed
Copy link
Member

Motivation

Fixes #11703.
As described in the issue, we should update the minimum requirement for the cbor library, as we depend on some code which was introduced with cbor2==5.5.0.

Changes

  • Update the minimum version for cbor. No other changes are necessary, since in our dependency lock files we already pin the latest version (5.6.5).

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Dec 18, 2024
@alexrashed alexrashed added this to the 4.1 milestone Dec 18, 2024
@alexrashed alexrashed requested a review from silv-io December 18, 2024 16:05
@alexrashed alexrashed self-assigned this Dec 18, 2024
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 50m 31s ⏱️ +6s
3 901 tests ±0  3 594 ✅ ±0  307 💤 ±0  0 ❌ ±0 
3 903 runs  ±0  3 594 ✅ ±0  309 💤 ±0  0 ❌ ±0 

Results for commit a038311. ± Comparison against base commit c76cc60.

@alexrashed alexrashed merged commit 5cefc0b into master Dec 18, 2024
36 checks passed
@alexrashed alexrashed deleted the update-min-cbor branch December 18, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Update cbor2 requirement
2 participants