Refactor/events/custom api destination #12057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149ae67 to
b1e2ae5
Compare
…in connection object
f0c41ce to
e5bf3bf
Compare
zaingz
approved these changes
Jan 8, 2025
zaingz
reviewed
Jan 8, 2025
| return errors | ||
|
|
||
| @staticmethod | ||
| def _validate_connection_arn(connection_arn: ConnectionArn) -> list[str]: |
There was a problem hiding this comment.
nit: might be good to move the regexes to utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor the functionality related to
connectionandapi destinationto be in line with the other event bridge provider functionality. Decouple data from functions via nested DTO and service object.Changes
For
connection:For
api destinationTesting
All existing connection and API destination crud tests as well as testing the target pass