Skip to content

fix client factory for bypassing DNS server #12059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix client factory for bypassing DNS server #12059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9884b09
filter DNS answer to only include A records
bentsku Dec 20, 2024
b898b8c
add better exception handling if no A record is found
bentsku Dec 20, 2024
5037582
replace `TYPE0` by `NONE
bentsku Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion localstack-core/localstack/aws/connect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,14 @@ def resolve_dns_from_upstream(hostname: str) -> str:
if len(response.answer) == 0:
raise ValueError(f"No DNS response found for hostname '{hostname}'")

ip_addresses = list(response.answer[0].items.keys())
ip_addresses = []
for answer in response.answer:
if answer.match(dns.rdataclass.IN, dns.rdatatype.A, dns.rdatatype.NONE):
ip_addresses.extend(answer.items.keys())

if not ip_addresses:
raise ValueError(f"No DNS records of type 'A' found for hostname '{hostname}'")

return choice(ip_addresses).address


Expand Down
Loading