Skip to content

Conversation

cloutierMat
Copy link
Contributor

Motivation

Implementation of the read and list operations for lambda layer versions.

The cloudformation schema were out of date so they were also updated as part of this pr.

Changes

  • Fix a bug in get_layer_versions where store.layers.get(layer_name, {}).layer_versions.get(layer_version) would fail when the lambda layer did not exists
  • Updated the Primary Identifier from Id to LayerVersionArn with a validated test
  • Implementation of read and list

@cloutierMat cloutierMat added aws:cloudformation AWS CloudFormation aws:lambda AWS Lambda semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Dec 20, 2024
@cloutierMat cloutierMat added this to the 4.1 milestone Dec 20, 2024
@cloutierMat cloutierMat self-assigned this Dec 20, 2024
@cloutierMat cloutierMat force-pushed the cfn-support-layer-version-read-list branch from 8ecfe28 to 2592afa Compare December 20, 2024 22:44
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 50m 15s ⏱️ - 1m 42s
3 903 tests +1  3 596 ✅ +1  307 💤 ±0  0 ❌ ±0 
3 905 runs  +1  3 596 ✅ +1  309 💤 ±0  0 ❌ ±0 

Results for commit 2592afa. ± Comparison against base commit 96eec2e.

Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great to have the schema updated. 👍

@cloutierMat cloutierMat merged commit 61535b7 into master Dec 23, 2024
31 checks passed
@cloutierMat cloutierMat deleted the cfn-support-layer-version-read-list branch December 23, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:cloudformation AWS CloudFormation aws:lambda AWS Lambda semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants