-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Relax healthcheck time constraints #12067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax healthcheck time constraints #12067
Conversation
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for opening a PR and providing a fix for the issue. Looking at the logs of the linked issue, it seems the command was taking around 5.2 seconds to run, leading into the timeout issue.
I think the 10s
timeout is a good change, as the interval is 10s
anyway. However, diminishing the number of retries might lead to unexpected changes for other users, as before the container had around 15s of start period + 4 interval of 10s + last retry of 5s timeout, and it will now be 15s + 2 interval of 10s + last retry of 10s.
Would you mind reverting the change of retries and then the PR would be good to merge. Thanks again for your contribution 🙏
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome, thanks a lot for being so reactive in pushing the changes. Sorry for the delay in reviewing this PR with the holiday season. Thanks again for your PR, and welcome to the contributors of LocalStack!
Motivation
Fix issue: #11259
Changes
Relaxed time constraints in healthcheck