Skip to content

allow setting of customId on IAM Policies #12073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

allow setting of customId on IAM Policies #12073

merged 1 commit into from
Jan 3, 2025

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Dec 26, 2024 •
edited
Loading

Motivation

This PR allows the setting of a CustomId for IAM Policies. /cc @cloutierMat

Changes

  • Check if the specific tag exists and then set the policy Id after its creation.

Testing

This is done in another repository.

@pinzon pinzon added the semver: patch Non-breaking changes which can be included in patch releases label Dec 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2024 •
edited
Loading

LocalStack Community integration with Pro

 2 files  ±    0   2 suites  ±0   21s ⏱️ - 1h 54m 54s
38 tests  - 3 882  34 ✅  - 3 579  4 💤  - 303  0 ❌ ±0 
40 runs   - 3 882  34 ✅  - 3 579  6 💤  - 303  0 ❌ ±0 

Results for commit c6da6f5. ± Comparison against base commit 186ecf0.

This pull request removes 3882 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@pinzon pinzon marked this pull request as ready for review December 26, 2024 15:51
@pinzon pinzon requested a review from dfangl as a code owner December 26, 2024 15:51
@pinzon pinzon force-pushed the replicator/iam-policies branch from 8f160f1 to 504e919 Compare December 27, 2024 17:12
@pinzon pinzon force-pushed the replicator/iam-policies branch from 504e919 to c6da6f5 Compare January 3, 2025 20:02
@pinzon pinzon merged commit 65277e5 into master Jan 3, 2025
31 checks passed
@pinzon pinzon deleted the replicator/iam-policies branch January 3, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinzon @dfangl