Bugfix/eventbridge/step functions target id input key #12099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8423162 to
edaecc3
Compare
edaecc3 to
e5e5bc1
Compare
|
Hey @maxhoheiser @silv-io, is there any chance for moving it forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some target senders rely on specific fields from the event e.g. the event id, if an input transformer or input path is applied to the event, these keys could be removed, and the sending of the event will fail.
This PR fixes the problem addresses in this github bug report: #11970
Changes
Optionally supply the input_event (no input transformer or input path applied for transformation) to the respective send_event method of Kinesis sender and Step Functions sender.
Testing
Add test send event to target kinesis with input transformer enabled
Add test send event to target step functions with input transformer enabled