Skip to content

Add tests to source package exclusions in MANIFEST.in #12108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add tests to source package exclusions in MANIFEST.in #12108

merged 2 commits into from
Jan 7, 2025

Conversation

silv-io
Copy link
Member

@silv-io silv-io commented Jan 7, 2025 •
edited
Loading

Motivation

The source package currently includes all tests, which makes it quite big (10MB). This happens because its inclusions/exclusions are not managed in pyproject.toml but in the older MANIFEST.in.
Our MANIFEST.in also contains some outdated paths in there.

Changes

  • Add exclusions for the tests in the source distribution
  • Update/Remove outdated paths in MANIFEST.in

Testing

drwxr-xr-x@    - silvio staff  7 Jan 12:17 localstack_core-4.0.4.dev85
.rw-r--r--@ 2.4M silvio staff  7 Jan 12:18 localstack_core-4.0.4.dev85-py3-none-any.whl
.rw-r--r--@  10M silvio staff  7 Jan 12:17 localstack_core-4.0.4.dev85.tar.gz
drwxr-xr-x@    - silvio staff  7 Jan 12:20 localstack_core-4.0.4.dev86
.rw-r--r--@ 2.4M silvio staff  7 Jan 12:20 localstack_core-4.0.4.dev86-py3-none-any.whl
.rw-r--r--@ 4.3M silvio staff  7 Jan 12:20 localstack_core-4.0.4.dev86.tar.gz

The size of the source distribution reduces by 57%.
Checking the contents shows that tests are not included anymore.

@silv-io silv-io requested review from alexrashed and dfangl January 7, 2025 11:27
@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Jan 7, 2025
alexrashed
alexrashed approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for jumping on this! 🚀 💯

dfangl
dfangl approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 52m 43s ⏱️ +6s
3 933 tests +8  3 626 ✅ +8  307 💤 ±0  0 ❌ ±0 
3 935 runs  +8  3 626 ✅ +8  309 💤 ±0  0 ❌ ±0 

Results for commit 8d427da. ± Comparison against base commit a24f409.

@silv-io silv-io merged commit b7ed5bc into master Jan 7, 2025
31 checks passed
@silv-io silv-io deleted the exclude-tests-from-package branch January 7, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@dfangl dfangl dfangl approved these changes

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silv-io @alexrashed @dfangl