Skip to content

Fix SSM parameter handling with paths and queries by ARN #12116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix SSM parameter handling with paths and queries by ARN #12116

merged 1 commit into from
Jan 13, 2025

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Jan 9, 2025 •
edited
Loading

Motivation

SSM does not properly return parameters stored when querying it by ARN, if the parameter has a path.

We have some logic to "normalize" the parameter name before passing the call to moto, and this logic is flawed when using an ARN to get the parameter, as the normalized name only contains the last segment of the path.

Changes

  • SSM now properly handles ARNs in its get_parameter and get_parameters operations, if the parameter contains a path.

@dfangl dfangl self-assigned this Jan 9, 2025
@dfangl dfangl force-pushed the ssm-parameters-leading-slash branch from 58f390c to c5556b3 Compare January 9, 2025 09:39
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   21m 2s ⏱️ - 1h 29m 30s
434 tests  - 3 511  323 ✅  - 3 313  111 💤  - 198  0 ❌ ±0 
436 runs   - 3 511  323 ✅  - 3 313  113 💤  - 198  0 ❌ ±0 

Results for commit c5556b3. ± Comparison against base commit ec18ec9.

This pull request removes 3512 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.ssm.test_ssm.TestSSM ‑ test_parameters_with_path

simonrw
simonrw reviewed Jan 9, 2025
View reviewed changes
@dfangl dfangl merged commit c6d7896 into master Jan 13, 2025
34 of 35 checks passed
@dfangl dfangl deleted the ssm-parameters-leading-slash branch January 13, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw left review comments

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@dfangl dfangl

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfangl @simonrw