StepFunctions, improve the use of ItemsPath declarations in Distributed Map states #12117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files 2 suites 33m 33s ⏱️ Results for commit c71d919. |
joe4dev
approved these changes
Jan 9, 2025
| self.items_path.eval(env=env) | ||
| # ItemsPath in DistributedMap states is only used if a JSONinput is passed from the previous state. | ||
| if ( | ||
| not isinstance(self.iteration_component, DistributedIterationComponent) |
There was a problem hiding this comment.
sidenote: complexity is with instance check is probably something to keep an eye on in the future if this would become a common pattern, but it's good to learn about such special cases first :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Step Functions, ItemsPath declarations within Distributed Map state are evaluated only if a JSON input is passed from a previous state in the workflow https://docs.aws.amazon.com/step-functions/latest/dg/input-output-itemspath.html. However, in the current implementation of the SFN v2 interpreter, ItemsPath declarations are always evaluated if declared. This can lead to evaluation failues if the provided path does not exist; AWS instead appears to simply skip the evaluation. These changes evaluate ItemsPath declarations only if this is the only input form for a Distributed Map state, or the Map state is inline. Relevant positive and negative snapshot tests are added.
Changes