-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update ASF APIs #12145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ASF APIs #12145
Conversation
It seems some changes in botocore might need some S3 snapshot updates, so I'll take care of that 😄 |
d7b6b8c
to
5e24f9d
Compare
@silv-io @alexrashed I've pushed the necessary changes for this PR to get in. I had to refresh most of S3 snapshots, which of course also put into a light a few changes in AWS parity. Regarding S3 data integrity, the big changes of this PR:
It put into lights some changes for a few "resources":
I'll track those changes to be updated later, and will start working on S3 data integrity straight away as I believe it might block users in some ways, depending on SDK behavior. The changes are leading to quite few unhappy people, as it wasn't really announced before and led to a lot of 3rd parties breaking. |
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 4m 52s ⏱️ Results for commit b3af693. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🚀 ASF Update Report 🚀
This PR has been automatically generated to update the generated API stubs for our ASF services.
It uses the latest code-generator from the master branch (scaffold.py) and the latest published version of botocore to re-generate all API stubs which are already present in the
localstack.aws.api
module of the master branch.🔄 Updated Services
This PR updates the following services:
👷🏽 Handle this PR
The following options describe how to interact with this PR / the auto-update:
✔️ Accept Changes
If the changes are satisfying, just squash-merge the PR and delete the source branch.
🚫 Ignore Changes
If you want to ignore the changes in this PR, just close the PR and do not delete the source branch. The PR will not be opened and a new PR will not be created for as long as the generated code does not change (or the branch is deleted). As soon as there are new changes, a new PR will be created.
✏️ Adapt Changes
Don't do this. The APIs are auto-generated. If you decide that the APIs should look different, you have to change the code-generation.
⏸️ Pause Updates
Remove the cron-schedule trigger of the GitHub Action workflow which creates these PRs. The action can then still be triggered manually, but it will not be executed automatically.