Skip to content

Update ASF APIs #12145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Update ASF APIs #12145

merged 13 commits into from
Jan 22, 2025

Conversation

localstack-bot
Copy link
Collaborator

🚀 ASF Update Report 🚀

This PR has been automatically generated to update the generated API stubs for our ASF services.
It uses the latest code-generator from the master branch (scaffold.py) and the latest published version of botocore to re-generate all API stubs which are already present in the localstack.aws.api module of the master branch.

🔄 Updated Services

This PR updates the following services:

  • ec2
  • route53
  • s3
  • transcribe

👷🏽 Handle this PR

The following options describe how to interact with this PR / the auto-update:

✔️ Accept Changes
If the changes are satisfying, just squash-merge the PR and delete the source branch.

🚫 Ignore Changes
If you want to ignore the changes in this PR, just close the PR and do not delete the source branch. The PR will not be opened and a new PR will not be created for as long as the generated code does not change (or the branch is deleted). As soon as there are new changes, a new PR will be created.

✏️ Adapt Changes
Don't do this. The APIs are auto-generated. If you decide that the APIs should look different, you have to change the code-generation.

⏸️ Pause Updates
Remove the cron-schedule trigger of the GitHub Action workflow which creates these PRs. The action can then still be triggered manually, but it will not be executed automatically.

@localstack-bot localstack-bot added area: dependencies Pull requests that update a dependency file semver: patch Non-breaking changes which can be included in patch releases labels Jan 20, 2025
Copy link

github-actions bot commented Jan 20, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 51m 36s ⏱️ - 1m 14s
3 984 tests +1  3 667 ✅ ±0  317 💤 +1  0 ❌ ±0 
3 986 runs  +1  3 667 ✅ ±0  319 💤 +1  0 ❌ ±0 

Results for commit b3af693. ± Comparison against base commit ece83c8.

♻️ This comment has been updated with latest results.

@bentsku
Copy link
Contributor

bentsku commented Jan 20, 2025

It seems some changes in botocore might need some S3 snapshot updates, so I'll take care of that 😄
This is the page about the new S3 data integrity: https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html

@bentsku bentsku self-assigned this Jan 21, 2025
@bentsku
Copy link
Contributor

bentsku commented Jan 21, 2025

@silv-io @alexrashed I've pushed the necessary changes for this PR to get in. I had to refresh most of S3 snapshots, which of course also put into a light a few changes in AWS parity.

Regarding S3 data integrity, the big changes of this PR:

  • I've updated some logic in order to not block customers with Multipart Uploads, so I've removed a bit of validation, but did not implement the new one
  • I've skipped all the new fields and will tackle this in a follow up

It put into lights some changes for a few "resources":

  • ObjectLock/ObjectRetention: error message changed, updated the very easy ones and skipped the others
  • BucketLifecycle: a new field has been added, I've skipped it for now
  • SSE-C encryption: updated error message, I already had a branch ongoing to fix that, will base it on this one

I'll track those changes to be updated later, and will start working on S3 data integrity straight away as I believe it might block users in some ways, depending on SDK behavior. The changes are leading to quite few unhappy people, as it wasn't really announced before and led to a lot of 3rd parties breaking.

Copy link

github-actions bot commented Jan 21, 2025

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   4m 52s ⏱️
442 tests 389 ✅  53 💤 0 ❌
884 runs  778 ✅ 106 💤 0 ❌

Results for commit b3af693.

♻️ This comment has been updated with latest results.

Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@silv-io silv-io merged commit 889c8c5 into master Jan 22, 2025
38 checks passed
@silv-io silv-io deleted the asf-auto-updates branch January 22, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: asf area: dependencies Pull requests that update a dependency file semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants