Remove deprecated Java-based event ruler #12158
Conversation
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 4m 52s ⏱️ Results for commit c6f3cc8. ♻️ This comment has been updated with latest results. |
|
I've tried running E File "<>/localstack/localstack-core/localstack/services/events/provider.py", line 1183, in start_replay
E events_to_replay = archive_service.get_events(
E ^^^^^^^^^^^^^^^^^^^^^^^^^^^
E File "<>/localstack/localstack-core/localstack/services/events/archive.py", line 133, in get_events
E events_to_replay = self._filter_events_start_end_time(start_time, end_time)
E ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E File "<>/localstack/localstack-core/localstack/services/events/archive.py", line 182, in _filter_events_start_end_time
E return [
E ^
E File "<>/localstack/localstack-core/localstack/services/events/archive.py", line 185, in <listcomp>
E if event_start_time <= self._normalize_datetime(event["time"]) <= event_end_time
E ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E File "<>/localstack/localstack-core/localstack/services/events/archive.py", line 174, in _normalize_datetime
E return dt.replace(second=0, microsecond=0)
E ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E TypeError: str.replace() takes no keyword argumentsMight be worth investigating somewhere else than here, but I think we might be good now with no tests failing due to the event rule engine? |
Yes, I came to the same conclusion. Even using the Java engine, |
f026995 to
c6f3cc8
Compare
Motivation
With the new native event rule engine introduced in 4.0.3, we deprecated the Java-based event rule engine to mitigate runtime conflicts if used simultaneously with the StepFunctions JSONata feature.
Changes
EVENT_RULE_ENGINEImplications
Apart from the failing test👉 Turns out to be an unrelated provider bug, failing with a TypeError even with the Java engine. Clarified the skip message accordingly.test_start_list_describe_canceled_replaywith the Python-based event rule engine, we are unaware of other regressions.