Fix legacy test that broke pipeline after eventbridge cron update #12160
Conversation
There was a problem hiding this comment.
LGTM! Thanks for jumping on this 🦸♀️ great fix, nice seeing another test being validated and now understanding why it failed before. The comment on the invalid CRON is also very useful because it was hard to understand why it would fail!
Also kudos for adding the snapshot test 🚀 we can have even more confidence in the test now!
94481c6 to
d4cf1c8
Compare
There was a problem hiding this comment.
Awesome work @anisaoshafi and super fast fix 👏👏👏
Feel free to add a conditional skip for the EventBridge v1 provider
@pytest.mark.skipif(
is_old_provider(),
reason="V1 provider does not support this feature",
)
Thanks a lot @joe4dev for sharing that hint. I was wondering why tests were failing on v1 provider. |
Would you mind to briefly explain why these tests don't work on events version 1? 👀 |
Sure, in the latest CircleCI run, I see 5 failing tests in v1 all parametrized versions of I think this invalid schedule detection was just not implemented in v1 and somehow the v1 tests were not executed in the PR adding the tests here: https://github.com/localstack/localstack/pull/12156/files#diff-9f5c75eb50435206aabd8d5e75726710c0ae1da04aea56b14a51eacf2e82dde4R322 |
d4cf1c8 to
e74d82c
Compare
Motivation
After merging this PR on eventbridge schedule validation, this integration test broke the pipeline:
test_event_rule_creation_without_target.That PR actually brought more parity with AWS and broke an existing test that shouldn't have passed.
Now the test is aws_validated 🚀
Changes
events_rule_without_targets.yaml.'cron(0 1 * * * *)'-->'cron(0 1 * * ? *)'