Skip to content

StepFunctions: AWS-SDK Integration Retain Specific Error Names #12161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

StepFunctions: AWS-SDK Integration Retain Specific Error Names #12161

merged 1 commit into from
Jan 22, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Jan 22, 2025

Motivation

This PR addresses an issue in the Step Functions AWS-SDK integration where, upon integration failure, the error name is incorrectly cast to a fixed StatesError. This behavior prevents workflows from catching specific error types and implementing retry logic tailored to particular failures in the AWS-SDK integration: #12139

Changes

  • aws-sdk error decoration logic uses the computed exception name
  • added relevant snapshot test

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jan 22, 2025
@MEPalma MEPalma added this to the 4.1 milestone Jan 22, 2025
@MEPalma MEPalma self-assigned this Jan 22, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   33m 12s ⏱️ - 1h 20m 21s
1 403 tests  - 2 592  1 332 ✅  - 2 345  71 💤  - 246  0 ❌  - 1 
1 405 runs   - 2 592  1 332 ✅  - 2 345  73 💤  - 246  0 ❌  - 1 

Results for commit e660890. ± Comparison against base commit b4b0ab9.

This pull request removes 2593 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.stepfunctions.v2.error_handling.test_aws_sdk.TestAwsSdk ‑ test_s3_no_such_key

joe4dev
joe4dev approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and clear test case 👏

@MEPalma MEPalma merged commit 14b3a06 into master Jan 22, 2025
36 checks passed
@MEPalma MEPalma deleted the MEP-sfn-aws_sdk_integration_error_name branch January 22, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@gregfurman gregfurman Awaiting requested review from gregfurman

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @joe4dev