Skip to content

fix: Explicitly stop ESM workers on LocalStack shutdown #12203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix: Explicitly stop ESM workers on LocalStack shutdown #12203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions localstack-core/localstack/services/lambda_/event_source_mapping/esm_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ def __init__(
def uuid(self) -> str:
return self.esm_config["UUID"]

def stop_for_shutdown(self):
# Signal the worker's poller_loop thread to gracefully shutdown
# TODO: Once ESM state is de-coupled from lambda store, re-think this approach.
self._shutdown_event.set()

def create(self):
if self.enabled:
with self._state_lock:
Expand Down
3 changes: 3 additions & 0 deletions localstack-core/localstack/services/lambda_/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,9 @@ def on_after_init(self):
get_runtime_executor().validate_environment()

def on_before_stop(self) -> None:
for esm_worker in self.esm_workers.values():
esm_worker.stop_for_shutdown()

# TODO: should probably unregister routes?
self.lambda_service.stop()
# Attempt to signal to the Lambda Debug Mode session object to stop.
Expand Down
Loading