restructure unit tests #12221
Merged
restructure unit tests #12221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiurin
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Nice improvement for tests maintainability @bentsku! Especially that some of the tests have already been under services. It's great that now we follow the same convention both inside unit tests and between unit and integration ones! 👏
alexrashed
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to be easier to use test selection against our unit tests, and to fit a common format with our integration tests, this PR refactor our unit tests structure to both fit the rules, and be clearer. The AWS services unit tests were mixed up with common utils tests, docker client tests and such.
This way, we don't need to worry about file naming, and for new tests being added, it will be clearer which structure to follow in order to properly trigger test selection.
We're going from
tests/unit/test_<service>.pytotests/unit/services/<service>/test_<whatever>.pyThe
CODEOWNERShave been manually updated, but our current generator is capable of handling the new format already and was already handling it, so it won't trigger issue.Changes