Step Functions: Improve Logging and Error Detection for Unsupported Service Integrations #12223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, only patch changes are allowed on master. Your PR labels (semver: minor) indicate that it cannot be merged into the master at this time. |
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 51m 52s ⏱️ -29s Results for commit 40b0b19. ± Comparison against base commit b4acd16. This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
gregfurman
approved these changes
Feb 10, 2025
| def from_state_props(self, state_props: StateProps) -> None: | ||
| super().from_state_props(state_props=state_props) | ||
| def _validate_service_integration_is_supported(self): | ||
| # As no aws-sdk support catalog is available, let invalid aws-sdk integration to fail at runtime. |
There was a problem hiding this comment.
nit: spelling
Suggested change
| # As no aws-sdk support catalog is available, let invalid aws-sdk integration to fail at runtime. | |
| # As no aws-sdk support catalog is available, allow invalid aws-sdk integration to fail at runtime. |
| @@ -25,6 +25,10 @@ class StateTaskServiceUnsupported(StateTaskServiceCallback): | |||
| def __init__(self): | |||
| super().__init__(supported_integration_patterns=_SUPPORTED_INTEGRATION_PATTERNS) | |||
|
|
|||
| def _validate_service_integration_is_supported(self): | |||
| # Attempts to execute any derivation logging this incident on creation. | |||
There was a problem hiding this comment.
nit: grammar
Suggested change
| # Attempts to execute any derivation logging this incident on creation. | |
| # Attempts to execute any derivation; logging this incident on creation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the Step Functions V2 interpreter does not check nor log unsupported API actions for supported optimized service integrations at creation time, leading to a lack of visibility for users (#12210). Additionally, when a boto schema for the request and/or return type is unavailable, the normalization logic proceeds without logging the issue, leading to misleading error messages for unsupported api actions (#12210). Similarly, unsupported service tasks are only checked at runtime, which delays error detection.
Changes