Skip to content

[ESM] Provide SqsPoller with default parameters #12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

[ESM] Provide SqsPoller with default parameters #12240

merged 1 commit into from
Feb 10, 2025

Conversation

gregfurman
Copy link
Contributor

Motivation

Provides default configuration values to the SqsPoller in the event that configuration is not set via the PipeSourceSqsQueueParameters dictionary.

Changes

  • The following defaults have been added to the SqsPoller
    • batch size defaults to 10
    • batch window defaults to 0 -- which is short polling by default. Note: batch windows are not yet implemented in the SqsPoller so this value doesn't get used anywhere.

@gregfurman gregfurman self-assigned this Feb 10, 2025
@gregfurman gregfurman added semver: patch Non-breaking changes which can be included in patch releases aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) labels Feb 10, 2025
@gregfurman gregfurman marked this pull request as ready for review February 10, 2025 11:25
silv-io
silv-io approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±  0      2 suites  ±0   1h 30m 2s ⏱️ - 22m 19s
3 102 tests  - 989  2 883 ✅  - 892  219 💤  - 97  0 ❌ ±0 
3 104 runs   - 989  2 883 ✅  - 892  221 💤  - 97  0 ❌ ±0 

Results for commit b681f9d. ± Comparison against base commit b4acd16.

This pull request removes 989 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@gregfurman gregfurman merged commit 2a2dfb0 into master Feb 10, 2025
36 checks passed
@gregfurman gregfurman deleted the fix/poller/batch-window-param branch February 10, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiurin tiurin tiurin approved these changes

@silv-io silv-io silv-io approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

Assignees

@gregfurman gregfurman

Labels
aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregfurman @tiurin @silv-io