[ESM] Correctly enable exponential backoff inside stream poller #12312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would classify this as a "minor" change, since it effectively activates the changes in #12281, which was also minor. |
|
Currently, only patch changes are allowed on master. Your PR labels (type: bug, semver: minor, aws:lambda:event-source-mapping) indicate that it cannot be merged into the master at this time. |
LocalStack Community integration with Pro 2 files 2 suites 1h 31m 2s ⏱️ Results for commit f9352fe. ♻️ This comment has been updated with latest results. |
|
@dfangl This minor label job is still failing. Let me rebase and push |
20d4e1f to
f9352fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A follow-up PR to #12281 that correctly initialises the exponential backoff object.
Changes
attemptcounter to the boff object. Instead, theMaximumRetryAttemptsattribute of the ESM config is used.