add service catalog cache loading from static var #12314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 9m 1s ⏱️ Results for commit 2788a41. ♻️ This comment has been updated with latest results. |
fbcedbe to
a17ca5e
Compare
pickle persists the module name when being dumped, which is main in case of the execution as module. This is not an issue when using dill, which is an install dependency already.
a17ca5e to
2788a41
Compare
silv-io
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the release of LocalStack 4.1.0, we had issues with the smoke tests of the binary build of our CLI.
It turned out that the initial loading of the service catalog took more than 2 seconds (which is the default connection timeout of
localstack wait). localstack/localstack-cli#33 introduced a workaround for this, by triggering the service catalog cache creation with a call prior to thelocalstack waitcommand.However, this issue has a user impact, as this cache will always be created when localstack is started with a new
botocoreversion (even if the localstack volume dir is properly configured).In fact, this was already discussed with @thrau when he introduced the cache in the first place (#6672).
This PR solves this issue by generating the service catalog index cache at docker build time and stores it directly in the Docker image (~650kb uncompressed).
Changes
get_service_catalogfrom theservice_routerto thespecmodule./usr/lib/localstack/).mainto the spec which allows to easily generate aServiceCatalogindex cache file to the static libs dir.Testing