Skip to content

Skip flaky Kinesis Lambda test #12328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Skip flaky Kinesis Lambda test #12328

merged 1 commit into from
Mar 3, 2025

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Mar 3, 2025

Motivation

This non-aws validated test seems flaky: https://github.com/localstack/localstack/actions/runs/13634627127/job/38110211627#step:22:7603

FAILED ../../localstack/tests/aws/test_integration.py::test_kinesis_lambda_forward_chain - botocore.errorfactory.ResourceInUseException: An error occurred (ResourceInUseException) when calling the PutRecord operation: Stream arn:aws:kinesis:us-east-1:000000000000:stream/test-stream-82a63827 is not currently ACTIVE or UPDATING.

Locally, I'm getting another assertion error:

>           raise Exception("Expected object not found: %s in list %s" % (expected_object, all_objects))
E           Exception: Expected object not found: {'test_data': 'forward_chain_data_ad49f8c0 with \'quotes\\"'} in list []

A workaround could be waiter for the stream to be active:

    wait_for_stream_ready(stream1_name)
    wait_for_stream_ready(stream2_name)

However, we should question whether the test is still needed, especially given it's not aws-validated

Changes

Skip flaky test

@joe4dev joe4dev self-assigned this Mar 3, 2025
@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Mar 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

LocalStack Community integration with Pro

 2 files  ±    0   2 suites  ±0   4m 25s ⏱️ - 1h 48m 3s
26 tests  - 4 081  23 ✅  - 3 751  3 💤  - 329  0 ❌  - 1 
28 runs   - 4 081  23 ✅  - 3 751  5 💤  - 329  0 ❌  - 1 

Results for commit 58561fc. ± Comparison against base commit dd0d96e.

This pull request removes 4081 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
This pull request skips 1 test. 
tests.aws.test_integration ‑ test_kinesis_lambda_forward_chain

@tiurin tiurin merged commit 0c50584 into master Mar 3, 2025
33 of 34 checks passed
@tiurin tiurin deleted the skip-flaky-kinesis-lambda-test branch March 3, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiurin tiurin tiurin approved these changes

Assignees

@joe4dev joe4dev

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe4dev @tiurin