Skip to content

[ESM] Fix validation of StartingPosition streams parameter #12329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

[ESM] Fix validation of StartingPosition streams parameter #12329

merged 1 commit into from
Mar 4, 2025

Conversation

gregfurman
Copy link
Contributor

Motivation

Adds validations for an ESM stream's StartingPosition parameter.

Changes

  • Extends the dynamodbstreams test test_create_event_source_validation to include some invalid/incompatible params
  • Adds a test_create_event_source_validation_kinesis to test for kinesis parameter validations.

@gregfurman gregfurman added type: bug Bug report semver: patch Non-breaking changes which can be included in patch releases aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) labels Mar 3, 2025
@gregfurman gregfurman added this to the 4.3 milestone Mar 3, 2025
@gregfurman gregfurman self-assigned this Mar 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±  0      2 suites  ±0   1h 29m 28s ⏱️ - 23m 10s
3 114 tests  - 993  2 894 ✅  - 880  220 💤  - 113  0 ❌ ±0 
3 116 runs   - 993  2 894 ✅  - 880  222 💤  - 113  0 ❌ ±0 

Results for commit 51a9572. ± Comparison against base commit 0c50584.

This pull request removes 994 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.lambda_.test_lambda_api.TestLambdaEventSourceMappings ‑ test_create_event_source_validation_kinesis

♻️ This comment has been updated with latest results.

@gregfurman gregfurman force-pushed the fix/esm/starting-position branch from 18ead91 to 51a9572 Compare March 3, 2025 20:44
@gregfurman gregfurman marked this pull request as ready for review March 3, 2025 22:09
joe4dev
joe4dev approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refining and extending these Lambda ESM validations @gregfurman

@gregfurman gregfurman merged commit 8edf11f into master Mar 4, 2025
31 checks passed
@gregfurman gregfurman deleted the fix/esm/starting-position branch March 4, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

Assignees

@gregfurman gregfurman

Labels
aws:lambda:event-source-mapping AWS Lambda Event Source Mapping (ESM) semver: patch Non-breaking changes which can be included in patch releases type: bug Bug report
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@gregfurman @joe4dev