Use per-file-target-version to define Python 3.9 for CLI code #12362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fa2f58 to
b641829
Compare
silv-io
commented
Mar 11, 2025
Comment on lines
+196
to
+203
| # Only allow minimum version for code used in the CLI | ||
| "localstack-core/localstack/cli/**" = "py39" | ||
| "localstack-core/localstack/packages/**" = "py39" | ||
| "localstack-core/localstack/config.py" = "py39" | ||
| "localstack-core/localstack/constants.py" = "py39" | ||
| "localstack-core/localstack/utils/analytics/**" = "py39" | ||
| "localstack-core/localstack/utils/bootstrap.py" = "py39" | ||
| "localstack-core/localstack/utils/json.py" = "py39" |
There was a problem hiding this comment.
I'm unsure whether this set of files is correct or maybe even too much (e.g., in the case of the analytics code where I even had to remove a match statement)
There was a problem hiding this comment.
i think this is good for now! we can always remove files from here
thrau
approved these changes
Mar 11, 2025
Comment on lines
+196
to
+203
| # Only allow minimum version for code used in the CLI | ||
| "localstack-core/localstack/cli/**" = "py39" | ||
| "localstack-core/localstack/packages/**" = "py39" | ||
| "localstack-core/localstack/config.py" = "py39" | ||
| "localstack-core/localstack/constants.py" = "py39" | ||
| "localstack-core/localstack/utils/analytics/**" = "py39" | ||
| "localstack-core/localstack/utils/bootstrap.py" = "py39" | ||
| "localstack-core/localstack/utils/json.py" = "py39" |
There was a problem hiding this comment.
i think this is good for now! we can always remove files from here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As in dependent repositories, we have an issue with the ASF updates since the latest
ruffupdate. The definition of the Python 3.9 target version in linting/formatting leads to syntax errors when enabling preview features like we do in the ASF update action.To fix that, we need to define our versions correctly depending on if the code runs in the CLI or in the runtime (container)
Changes
py311matching our.python-versionper-file-target-versiontopy39for all code accessed in the CLI matching our minimum required versionpy311py39compatible (remove match statement fromusage.py)