Skip to content

chore: improve remaining tests snapshots #12373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

chore: improve remaining tests snapshots #12373

merged 1 commit into from
Mar 12, 2025

Conversation

giograno
Copy link
Member

Motivation

As we fixed a snapshot leading to a test failure in #12367, I thought it was worth briefly going all over the repository and doing the same.

Changes

  • Improve snapshots by matching the response instead of the exception info object.

@giograno giograno added the semver: patch Non-breaking changes which can be included in patch releases label Mar 12, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 28m 18s ⏱️ - 22m 27s
2 937 tests  - 1 188  2 722 ✅  - 1 083  215 💤  - 105  0 ❌ ±0 
2 939 runs   - 1 188  2 722 ✅  - 1 083  217 💤  - 105  0 ❌ ±0 

Results for commit 4196b19. ± Comparison against base commit 4f210f8.

This pull request removes 1188 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@giograno giograno requested a review from silv-io March 12, 2025 07:25
@giograno giograno marked this pull request as ready for review March 12, 2025 07:46
silv-io
silv-io approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks for handling these

@giograno giograno merged commit 1a6f9dd into master Mar 12, 2025
34 checks passed
@giograno giograno deleted the chore-improve-snapshot-v2 branch March 12, 2025 08:44
@giograno giograno mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silv-io silv-io silv-io approved these changes

@maxhoheiser maxhoheiser Awaiting requested review from maxhoheiser

@joe4dev joe4dev Awaiting requested review from joe4dev

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@pinzon pinzon Awaiting requested review from pinzon

@simonrw simonrw Awaiting requested review from simonrw

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giograno @silv-io