Skip to content

CFn updates: create new v2 provider for new engine #12375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Mar 12, 2025

Motivation

In order to make improvements to the CFn engine, we have decided to add a new provider to update the functionality. It is useful to be able to update the provider methods for specific operations (typically around change sets) to change the template preprocessing etc.

Changes

Add a new provider under the name engine-v2. This can be enabled with PROVIDER_OVERRIDE_CLOUDFORMATION=engine-v2. There is no implementation for now.

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Mar 12, 2025
@simonrw simonrw self-assigned this Mar 12, 2025
@simonrw simonrw requested a review from MEPalma March 12, 2025 11:06
@simonrw simonrw added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: patch Non-breaking changes which can be included in patch releases labels Mar 12, 2025
Copy link
Contributor

@MEPalma MEPalma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 51m 4s ⏱️ - 3m 4s
4 125 tests ±0  3 805 ✅ ±0  320 💤 ±0  0 ❌ ±0 
4 127 runs  ±0  3 805 ✅ ±0  322 💤 ±0  0 ❌ ±0 

Results for commit fd39cb6. ± Comparison against base commit 1a6f9dd.

@simonrw simonrw merged commit 257af99 into master Mar 12, 2025
38 checks passed
@simonrw simonrw deleted the cfn/provider-v2 branch March 12, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants