Skip to content

Lambda: Added Ruby 3.4 Runtime #12458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Lambda: Added Ruby 3.4 Runtime #12458

merged 1 commit into from
Apr 1, 2025

Conversation

anisaoshafi
Copy link
Contributor

@anisaoshafi anisaoshafi commented Mar 31, 2025 •
edited
Loading

Motivation

AWS announced support for Ruby 3.4 Lambda runtime on March 27th and we want to support it quickly.
https://aws.amazon.com/about-aws/whats-new/2025/03/aws-lambda-support-ruby-3-4/

Changes

  • Added support for the new Lambda runtime Ruby 3.4
  • Updated snapshots
  • Reverted some of the (temporary?) changes introduced in this PR for test_snapstart_lifecycle and test_snapstart_update_function_configuration: Allow usage of additional runtimes with the Lambda SnapStart feature enabled #12006 because AWS seems to not support snapstart enabled functions for many runtimes anymore (they seems to temporarily allow them 🤷🏼 ).
    botocore.errorfactory.InvalidParameterValueException: An error occurred (InvalidParameterValueException) when calling the CreateFunction operation: nodejs22.x is not supported for SnapStart enabled functions.
    Screenshot 2025-03-31 at 14 52 30

@anisaoshafi anisaoshafi added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases aws:lambda AWS Lambda labels Mar 31, 2025
@anisaoshafi anisaoshafi self-assigned this Mar 31, 2025
@anisaoshafi anisaoshafi marked this pull request as ready for review March 31, 2025 15:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 29m 24s ⏱️ - 26m 40s
3 131 tests  - 1 189  2 905 ✅  - 1 087  226 💤  - 102  0 ❌ ±0 
3 133 runs   - 1 189  2 905 ✅  - 1 087  228 💤  - 102  0 ❌ ±0 

Results for commit c8dccae. ± Comparison against base commit a6be285.

This pull request removes 1194 and adds 5 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.lambda_.test_lambda_common.TestLambdaCallingLocalstack ‑ test_manual_endpoint_injection[ruby3.4]
tests.aws.services.lambda_.test_lambda_common.TestLambdaRuntimesCommon ‑ test_echo_invoke[ruby3.4]
tests.aws.services.lambda_.test_lambda_common.TestLambdaRuntimesCommon ‑ test_introspection_invoke[ruby3.4]
tests.aws.services.lambda_.test_lambda_common.TestLambdaRuntimesCommon ‑ test_runtime_wrapper_invoke[ruby3.4]
tests.aws.services.lambda_.test_lambda_common.TestLambdaRuntimesCommon ‑ test_uncaught_exception_invoke[ruby3.4]

♻️ This comment has been updated with latest results.

@anisaoshafi anisaoshafi force-pushed the add-ruby-runtime branch 5 times, most recently from a93cb3d to 200d2c8 Compare March 31, 2025 18:45
joe4dev
joe4dev approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome how fast we can add new Lambda runtimes 🥳

Well done @anisaoshafi 🙌 🙌 🙌

localstack-core/localstack/services/lambda_/provider.py
@@ -718,6 +719,11 @@ def _validate_snapstart(snap_start: SnapStart, runtime: Runtime):
f"1 validation error detected: Value '{apply_on}' at 'snapStart.applyOn' failed to satisfy constraint: Member must satisfy enum value set: [PublishedVersions, None]"
)

if runtime not in SNAP_START_SUPPORTED_RUNTIMES:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@anisaoshafi anisaoshafi added this to the 4.4 milestone Apr 1, 2025
@anisaoshafi anisaoshafi merged commit 9383d50 into master Apr 1, 2025
31 checks passed
@anisaoshafi anisaoshafi deleted the add-ruby-runtime branch April 1, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@dfangl dfangl Awaiting requested review from dfangl

@gregfurman gregfurman Awaiting requested review from gregfurman

Assignees

@anisaoshafi anisaoshafi

Labels
aws:lambda AWS Lambda semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@anisaoshafi @joe4dev